virajjasani commented on code in PR #4592:
URL: https://github.com/apache/hbase/pull/4592#discussion_r912418398
##########
hbase-common/src/main/java/org/apache/hadoop/hbase/nio/RefCnt.java:
##########
@@ -31,7 +34,10 @@
@InterfaceAudience.Private
public class RefCnt extends AbstractReferenceCounted {
- private Recycler recycler = ByteBuffAllocator.NONE;
+ private static final ResourceLeakDetector<RefCnt> detector =
Review Comment:
Yeah makes sense, no need for separate config if same can be used for both
netty and hbase together.
When I tried ADVANCED leak detection in HBASE-26708, I hardly got any useful
hints, here is [the
comment](https://issues.apache.org/jira/browse/HBASE-26708?focusedCommentId=17482669&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17482669).
One question: have you also increased
`org.apache.hbase.thirdparty.io.netty.leakDetection.targetRecords` limit while
debugging the whole issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
