bbeaudreault commented on PR #4592: URL: https://github.com/apache/hbase/pull/4592#issuecomment-1173084084
No problem @Apache9 , thanks for taking a look. I will say that my change in HFileBlock is actually the same operations, just in a different order (allocate buffer, then clone, rather than clone then allocate). So then the only functional change is `withShared(!newBuf.hasArray())` rather than `withShared(blk.isSharedMem())`. Of course the leak detection may affect performance, but I might recommend running with leakDetection.level=DISABLED in production, in which case there should be no overhead. Hope that helps, let me know if you have any thoughts or questions when you take a look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
