[
https://issues.apache.org/jira/browse/HBASE-27206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17567560#comment-17567560
]
Andrew Kyle Purtell commented on HBASE-27206:
---------------------------------------------
Error prone finding fixes are very unlikely to change performance. Have a look
at the PRs to see for yourself [~vjasani]. 90% of the changes are javadoc
problems. Those are obviously not a performance issue. The remainder are code
smells, which we do not want in our code base. There _might_ be one or two
changes that prove controversial. If you find any, we can drop them, but I
think it unlikely. Also, I do not intend to hold up any 2.5 release for issues
like this. That said, code cleanliness is important, and we have error-prone
integrated in our builds for a reason, which is to warn us about bad patterns
and code smells, and correct them when we are warned about them, and it is
important to do so.
> Clean up error-prone findings in hbase-common
> ---------------------------------------------
>
> Key: HBASE-27206
> URL: https://issues.apache.org/jira/browse/HBASE-27206
> Project: HBase
> Issue Type: Sub-task
> Reporter: Andrew Kyle Purtell
> Assignee: Andrew Kyle Purtell
> Priority: Major
> Fix For: 2.5.0, 3.0.0-alpha-4
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
