[
https://issues.apache.org/jira/browse/HBASE-27206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17567574#comment-17567574
]
Viraj Jasani commented on HBASE-27206:
--------------------------------------
I see your point, I think it makes sense. The only reason why I was thinking
about doing more functional testing (sorry, not perf but overall functional
testing is what I meant, but we can use LTT, ITLCC etc also) is because the
changes are too many, but you are right that they are mostly fixes for code
smells and javadocs. I think reviewing every one of them might take time so in
the meantime we might want to run hbase-server and maybe some module tests as
well.
{quote}Also, I do not intend to hold up any 2.5 release for issues like this.
If for example they miss 2.5.0, 2.5.1 would be right around the corner.
{quote}
Sounds good.
{quote}That said, code cleanliness is important, and we have error-prone
integrated for a reason, which is to warn us about bad patterns and code
smells, and bad javadoc, and correct them when we are warned about them, and it
is important to do so.
{quote}
Totally agree. In order to reduce code changes, perhaps we can document/include
this step as part of RC preparation also?
> Clean up error-prone findings in hbase-common
> ---------------------------------------------
>
> Key: HBASE-27206
> URL: https://issues.apache.org/jira/browse/HBASE-27206
> Project: HBase
> Issue Type: Sub-task
> Reporter: Andrew Kyle Purtell
> Assignee: Andrew Kyle Purtell
> Priority: Major
> Fix For: 2.5.0, 3.0.0-alpha-4
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
