comnetwork commented on code in PR #4633:
URL: https://github.com/apache/hbase/pull/4633#discussion_r925547822


##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractFSWAL.java:
##########
@@ -142,7 +142,7 @@
     "hbase.regionserver.wal.slowsync.roll.interval.ms";
   protected static final int DEFAULT_SLOW_SYNC_ROLL_INTERVAL_MS = 60 * 1000; 
// in ms, 1 minute
 
-  protected static final String WAL_SYNC_TIMEOUT_MS = 
"hbase.regionserver.wal.sync.timeout";
+  public static final String WAL_SYNC_TIMEOUT_MS = 
"hbase.regionserver.wal.sync.timeout";

Review Comment:
   @Apache9 , after I read the code about WAL , I  have a question:
   For `AsyncFSWAL`, basically  `WAL.sync` could not throw any exception except 
that `TimeoutIOException`,
   but for `FSHLog`, `WAL.sync` could throw any exception thrown by 
`ProtobufLogWriter.append` and 
   `ProtobufLogWriter.sync ` ,  and when throwing these exceptions, it just 
requests the WAL rolling and does not abort the RegionServer, so for  
`AsyncFSWAL`,we could abort the RegionServer, but for `FSHLog`, it is not 
suitable to abort the RegionServer when `WAL.sync` throws the exception other 
than `TimeoutIOException` , we still need a  way to avoid the situation 
described by this issue.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to