comnetwork commented on code in PR #4633:
URL: https://github.com/apache/hbase/pull/4633#discussion_r925636963
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractFSWAL.java:
##########
@@ -142,7 +142,7 @@
"hbase.regionserver.wal.slowsync.roll.interval.ms";
protected static final int DEFAULT_SLOW_SYNC_ROLL_INTERVAL_MS = 60 * 1000;
// in ms, 1 minute
- protected static final String WAL_SYNC_TIMEOUT_MS =
"hbase.regionserver.wal.sync.timeout";
+ public static final String WAL_SYNC_TIMEOUT_MS =
"hbase.regionserver.wal.sync.timeout";
Review Comment:
@Apache9, ok, I think we could open two new jiras , one is for AsyncFSWAL
to abort the RegionServer for `TimeoutIOException`, and the other is to
implement the retry WAL entries logic of HLog as same as AsyncFSWAL , which is
a little more complicated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]