Apache9 commented on code in PR #4633:
URL: https://github.com/apache/hbase/pull/4633#discussion_r925576679
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractFSWAL.java:
##########
@@ -142,7 +142,7 @@
"hbase.regionserver.wal.slowsync.roll.interval.ms";
protected static final int DEFAULT_SLOW_SYNC_ROLL_INTERVAL_MS = 60 * 1000;
// in ms, 1 minute
- protected static final String WAL_SYNC_TIMEOUT_MS =
"hbase.regionserver.wal.sync.timeout";
+ public static final String WAL_SYNC_TIMEOUT_MS =
"hbase.regionserver.wal.sync.timeout";
Review Comment:
This is also a problem for the FSHLog implementation. Basically, if the
write to HDFS fails, we do not know whether the data has been persistent or
not. The implementation for AsyncFSWAL, is to open a new writer and try to
write the WAL entries again, and then adding logic in WAL split and replay to
deal with duplicate entries. So for FSHLog, if it is not easy to add the same
logic with AsyncFSWAL, the correct way is to abort the region server to let the
failover logic to detect whether the WAL entries have been persistent or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]