bbeaudreault commented on code in PR #4940:
URL: https://github.com/apache/hbase/pull/4940#discussion_r1064690832
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionScannerImpl.java:
##########
@@ -426,6 +426,8 @@ private boolean nextInternal(List<Cell> results,
ScannerContext scannerContext)
// Used to check time limit
LimitScope limitScope = LimitScope.BETWEEN_CELLS;
+ checkpoint(State.START);
Review Comment:
I've moved the initial checkpoint call into the constructor, so we only have
to do it once. The other checkpoint calls have been changed to a new
`checkpointIfFiltering` method which returns early if `filter == null`.
The initial checkpoint call is still important because it enables
`retainBlock()` functionality in StoreScanner. Someone could submit a scan with
`addColumn(...)` which looks for 1 column in rows with many columns. In which
case `retainBlock()` in StoreScanner would still be very useful. I added a
comment to explain that.
Thanks for looking!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
