bbeaudreault commented on code in PR #4940:
URL: https://github.com/apache/hbase/pull/4940#discussion_r1066082357
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionScannerImpl.java:
##########
@@ -426,6 +426,8 @@ private boolean nextInternal(List<Cell> results,
ScannerContext scannerContext)
// Used to check time limit
LimitScope limitScope = LimitScope.BETWEEN_CELLS;
+ checkpoint(State.START);
Review Comment:
@comnetwork I just pushed a commit which adds a `boolean
checkpointingEnabled` to the creation of HFileScannerImpl. This involves minor
modifications to many levels of `getScanner(...)` calls. I added the new param
everywhere necessary, defaulting to `false` everywhere. This retains the old
behavior for all usages. I then updated just StoreScanner to pass `true`, as
this is the only place we want to enable this behavior right now.
This is a bunch more small changes, but is probably the safest route. If
there were a bug where we accidentally passed false, we'd just be reverting to
the original behavior and losing the optimization. You can see how it affects
things in HFileReaderImpl.
Let me know what you think. I can revert that commit or we can keep it. As a
result I was able to simplify some of the checkpointing (default to 0 instead
of -1, no need to call checkpoint on new scanners).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
