[GitHub] [hbase] comnetwork commented on a diff in pull request #4940: HBASE-27227 Long running heavily filtered scans hold up too many ByteBuffAllocator buffers

[GitBox]

comnetwork commented on code in PR #4940:
URL: https://github.com/apache/hbase/pull/4940#discussion_r1065830598


##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionScannerImpl.java:
##########
@@ -426,6 +426,8 @@ private boolean nextInternal(List<Cell> results, 
ScannerContext scannerContext)
     // Used to check time limit
     LimitScope limitScope = LimitScope.BETWEEN_CELLS;
 
+    checkpoint(State.START);

Review Comment:
   @bbeaudreault , thank you very much for detailed reply. Overall LGTM, it is  
is really a very insightful pr, just have a smoen suggestions , FYI.
   Should we set  `HFileScannerImpl.lastCheckpointIndex` to  0 when 
initializing ? so we could simplify the 
       `if (shouldRetainBlock || lastCheckpointIndex < 0)`  in 
`HFileScannerImpl.handlePrevBlock` to 
   `if (shouldRetainBlock)`, after all, when we start to scan,
   `HFileScannerImpl.lastCheckpointIndex` is always >=0, no matter there is 
filter or not,  and we could also remove
   `checkpoint(State.START)` in `RegionScannerImpl` ctor.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org