bbeaudreault commented on code in PR #4967:
URL: https://github.com/apache/hbase/pull/4967#discussion_r1073472783
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java:
##########
@@ -3398,7 +3398,6 @@ private void scan(HBaseRpcController controller,
ScanRequest request, RegionScan
}
boolean mayHaveMoreCellsInRow =
scannerContext.mayHaveMoreCellsInRow();
Result r = Result.create(values, null, stale,
mayHaveMoreCellsInRow);
- lastBlock.setValue(addSize(rpcCall, r, lastBlock.getValue()));
Review Comment:
This call to `addSize` here is no longer necessary for the underlying scan,
because now we track blocks in the ScannerContext. This addSize call
increments the `rpcCall` response cell size and block size based on the
estimated block sizes. The new method is more accurate, and a few lines below
we call `rpcCall.incrementResponseBlockSize` and
`rpcCall.incrementResponseCellSize` to ensure the same rpc call accounting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
