bbeaudreault commented on code in PR #4967:
URL: https://github.com/apache/hbase/pull/4967#discussion_r1073473607
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionScannerImpl.java:
##########
@@ -705,13 +712,21 @@ public int size() {
protected boolean nextRow(ScannerContext scannerContext, Cell curRowCell)
throws IOException {
assert this.joinedContinuationRow == null : "Trying to go to next row
during joinedHeap read.";
+
+ // Enable skipping row mode, which disables limits and skips tracking
progress for all
+ // but block size. We keep tracking block size because skipping a row in
this way
+ // might involve reading blocks along the way.
+ scannerContext.setSkippingRow(true);
+
Cell next;
while ((next = this.storeHeap.peek()) != null &&
CellUtil.matchingRows(next, curRowCell)) {
// Check for thread interrupt status in case we have been signaled from
// #interruptRegionOperation.
region.checkInterrupt();
- this.storeHeap.next(MOCKED_LIST);
+ this.storeHeap.next(MOCKED_LIST, scannerContext);
Review Comment:
Yes, we used to pass in NoLimitsScannerContext here as the default. But now
we want to track block size. So the `setSkippingRow` state emulates
NoLimitsScannerContext.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
