bbeaudreault commented on code in PR #4967:
URL: https://github.com/apache/hbase/pull/4967#discussion_r1073488012
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionScannerImpl.java:
##########
@@ -608,6 +610,11 @@ private boolean nextInternal(List<Cell> results,
ScannerContext scannerContext)
return
scannerContext.setScannerState(NextState.NO_MORE_VALUES).hasMoreValues();
}
if (!shouldStop) {
+ // Read nothing as the cells were filtered, but still need to check
time limit.
Review Comment:
We want to check the size limit any time we are potentially continuing the
loop. This was the only case we missed, the others (which i converted from
checkTimeLimit to checkAnyLimit above) are all similar.
Since `nextRow` is now accumulating block size, we want to check after
calling nextRow to ensure we haven't exceeded the limit.
I could make this checkSizeLimit if you'd like. I made it
checkAnyLimitReached so that it is the same as the other calls above, which
were just checking time limit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
