bbeaudreault commented on code in PR #4770:
URL: https://github.com/apache/hbase/pull/4770#discussion_r1081929395
##########
hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat2.java:
##########
@@ -653,10 +664,9 @@ static void configureIncrementalLoad(Job job,
List<TableInfo> multiTableInfo,
for (TableInfo tableInfo : multiTableInfo) {
regionLocators.add(tableInfo.getRegionLocator());
- String tn = writeMultipleTables
- ?
tableInfo.getRegionLocator().getName().getNameWithNamespaceInclAsString()
- : tableInfo.getRegionLocator().getName().getNameAsString();
- allTableNames.add(tn);
+ allTableNames.add(writeToTableWithNamespace ?
Review Comment:
Just thinking that when we upgrade to 3.0, the code will be:
```
String tn = writeMultipleTables
?
tableInfo.getRegionLocator().getName().getNameWithNamespaceInclAsString()
: tableInfo.getRegionLocator().getName().getNameAsString();
```
and our new config will disappear. So if someone enabled
writeToTableWithNamespace in hbase2 (but not writeMultipleTables) and they go
to 3.0, they'll stop writing with the namespace included.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
