bbeaudreault commented on code in PR #4770:
URL: https://github.com/apache/hbase/pull/4770#discussion_r1081931496
##########
hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat2.java:
##########
@@ -152,6 +153,10 @@ protected static byte[] combineTableNameSuffix(byte[]
tableName, byte[] suffix)
static final String BLOCK_SIZE_FAMILIES_CONF_KEY =
"hbase.mapreduce.hfileoutputformat.blocksize";
static final String DATABLOCK_ENCODING_FAMILIES_CONF_KEY =
"hbase.mapreduce.hfileoutputformat.families.datablock.encoding";
+ public static final String TABLE_NAME_WITH_NAMESPACE_INCLUSIVE_KEY =
Review Comment:
can you just add a quick comment to this:
```
// When MULTI_TABLE_HFILEOUTPUTFORMAT_CONF_KEY is enabled, should table
names be written
// with namespace included.
// This will be the behavior when upgrading to 3.0.
```
##########
hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat2.java:
##########
@@ -152,6 +153,10 @@ protected static byte[] combineTableNameSuffix(byte[]
tableName, byte[] suffix)
static final String BLOCK_SIZE_FAMILIES_CONF_KEY =
"hbase.mapreduce.hfileoutputformat.blocksize";
static final String DATABLOCK_ENCODING_FAMILIES_CONF_KEY =
"hbase.mapreduce.hfileoutputformat.families.datablock.encoding";
+ public static final String TABLE_NAME_WITH_NAMESPACE_INCLUSIVE_KEY =
Review Comment:
can you just add a quick comment to this:
```
// When MULTI_TABLE_HFILEOUTPUTFORMAT_CONF_KEY is enabled, should table
names be written
// with namespace included.
// This will be the behavior when upgrading to hbase 3.0.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
