bbeaudreault commented on code in PR #4770:
URL: https://github.com/apache/hbase/pull/4770#discussion_r1081946531
##########
hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestHFileOutputFormat2.java:
##########
@@ -657,9 +657,9 @@ private void doIncrementalLoadTest(boolean
shouldChangeRegions, boolean shouldKe
assertEquals("HFOF should not touch actual table", 0,
util.countRows(tableSingle));
Review Comment:
this test method `doIncrementalLoadTest` is already parameterized. I wonder
if we could add a test for the new `writeToTableWithNamespace` mode. Basically
add a:
```
if (writeMultipleTables && writeToTableWithNamespace) {
testDir = new Path(testDir, "default");
}
```
Sort of like you had before, but now wrapped in a new boolean. We can then
add a new `@Test` method which passes true for that so we can verify that we
can write to the correct output dirs for both the old and new structure, when
configured appropriately.
##########
hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestHFileOutputFormat2.java:
##########
@@ -657,9 +657,9 @@ private void doIncrementalLoadTest(boolean
shouldChangeRegions, boolean shouldKe
assertEquals("HFOF should not touch actual table", 0,
util.countRows(tableSingle));
Review Comment:
Same in TestCellBasedHFileOutputFormat2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
