bbeaudreault commented on code in PR #5326:
URL: https://github.com/apache/hbase/pull/5326#discussion_r1268580365


##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncTableBuilder.java:
##########
@@ -137,6 +138,11 @@ default AsyncTableBuilder<C> setMaxRetries(int maxRetries) 
{
    */
   AsyncTableBuilder<C> setStartLogErrorsCnt(int startLogErrorsCnt);
 
+  /**
+   * Sets the map of request attributes
+   */
+  AsyncTableBuilder<C> setRequestAttributes(Map<String, byte[]> 
requestAttributes);

Review Comment:
   What do you think about `setRequestAttribute(String, byte[])` so that one 
can more fluently create their Table/AsyncTable if desired? One can chain 
together ImmutableMap.builder().add().add().build, but not everyone might have 
it and it's a bit more verbose.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to