bbeaudreault commented on code in PR #5326:
URL: https://github.com/apache/hbase/pull/5326#discussion_r1268602953
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncTableBuilder.java:
##########
@@ -137,6 +138,11 @@ default AsyncTableBuilder<C> setMaxRetries(int maxRetries)
{
*/
AsyncTableBuilder<C> setStartLogErrorsCnt(int startLogErrorsCnt);
+ /**
+ * Sets the map of request attributes
+ */
+ AsyncTableBuilder<C> setRequestAttributes(Map<String, byte[]>
requestAttributes);
Review Comment:
I don't have a strong opinion on whether we should continue to support
`setRequestAttributes` (with an s). Do you think that has a particular value as
is?
If we do support both, then yea we need to figure out the interplay. I agree
that calling set after add would overwrite, but what about add after set? One
could imagine someone calling set with an immutable map, so we'd probably have
to copy it in order to ensure add operations work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
