rmdmattingly commented on code in PR #5326:
URL: https://github.com/apache/hbase/pull/5326#discussion_r1268609796
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncTableBuilder.java:
##########
@@ -137,6 +138,11 @@ default AsyncTableBuilder<C> setMaxRetries(int maxRetries)
{
*/
AsyncTableBuilder<C> setStartLogErrorsCnt(int startLogErrorsCnt);
+ /**
+ * Sets the map of request attributes
+ */
+ AsyncTableBuilder<C> setRequestAttributes(Map<String, byte[]>
requestAttributes);
Review Comment:
> One could imagine someone calling set with an immutable map, so we'd
probably have to copy it in order to ensure add operations work.
Yeah that's a good point.
> I don't have a strong opinion on whether we should continue to support
setRequestAttributes (with an s). Do you think that has a particular value as
is?
I don't feel _particularly_ strongly, but it seems plausible that someone
will have a map of requests pre-constructed, particularly if they have several
attributes to pass, and that it would be nicer to pass it in than need to
iterate calls to addRA
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
