[
https://issues.apache.org/jira/browse/HBASE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13412484#comment-13412484
]
Zhihong Ted Yu commented on HBASE-4050:
---------------------------------------
Amazing work !
ReplicationMetricsSource javadoc is to be filled.
And some catch clauses have boilerplate code:
{code}
+ } catch (IOException e) {
+ e.printStackTrace(); //To change body of catch statement use File |
Settings | File Templates.
{code}
I thought author name shouldn't appear in the file header:
{code}
+ * author David Blevins
+ * version $Rev$ $Date$
{code}
Consider using uppercase M in the string below:
{code}
+ private static final String METRICS_CONTEXT = "replicationmetrics";
{code}
Do we need to check that delta is non-negative ?
{code}
+ gaugeInt.decr(delta);
{code}
Maybe give the assembly file a more descriptive name ?
{code}
+ <assembly.file>src/assembly/two.xml</assembly.file>
{code}
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceMetrics.java
is removed.
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/metrics2/ReplicationSourceMetrics.java
is added.
What about metrics1 ?
> Update HBase metrics framework to metrics2 framework
> ----------------------------------------------------
>
> Key: HBASE-4050
> URL: https://issues.apache.org/jira/browse/HBASE-4050
> Project: HBase
> Issue Type: New Feature
> Components: metrics
> Affects Versions: 0.90.4
> Environment: Java 6
> Reporter: Eric Yang
> Assignee: Alex Baranau
> Priority: Critical
> Fix For: 0.96.0
>
> Attachments: 4050-metrics-v2.patch, 4050-metrics-v3.patch,
> HBASE-4050-0.patch, HBASE-4050-1.patch, HBASE-4050.patch
>
>
> Metrics Framework has been marked deprecated in Hadoop 0.20.203+ and 0.22+,
> and it might get removed in future Hadoop release. Hence, HBase needs to
> revise the dependency of MetricsContext to use Metrics2 framework.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
