[
https://issues.apache.org/jira/browse/HBASE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13412509#comment-13412509
]
Elliott Clark commented on HBASE-4050:
--------------------------------------
bq.ReplicationMetricsSource javadoc is to be filled.
bq.And some catch clauses have boilerplate code
Agreed. I'll get a patch up soon.
bq.I thought author name shouldn't appear in the file header:
I was trying to keep the source as close to the original as possible. I'm open
for whatever; I was just trying to make sure that the people who wrote it got
credit.
bq.Consider using uppercase M in the string below
Hadoop's metrics2 uses all lowercase for context.
https://github.com/apache/hadoop-common/blob/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/impl/MetricsSystemImpl.java#L68
bq.Do we need to check that delta is non-negative ?
Nope. Hadoop doesn't so I followed suit.
bq.Maybe give the assembly file a more descriptive name ?
Sure
> Update HBase metrics framework to metrics2 framework
> ----------------------------------------------------
>
> Key: HBASE-4050
> URL: https://issues.apache.org/jira/browse/HBASE-4050
> Project: HBase
> Issue Type: New Feature
> Components: metrics
> Affects Versions: 0.90.4
> Environment: Java 6
> Reporter: Eric Yang
> Assignee: Alex Baranau
> Priority: Critical
> Fix For: 0.96.0
>
> Attachments: 4050-metrics-v2.patch, 4050-metrics-v3.patch,
> HBASE-4050-0.patch, HBASE-4050-1.patch, HBASE-4050.patch
>
>
> Metrics Framework has been marked deprecated in Hadoop 0.20.203+ and 0.22+,
> and it might get removed in future Hadoop release. Hence, HBase needs to
> revise the dependency of MetricsContext to use Metrics2 framework.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
