rmdmattingly commented on code in PR #5481:
URL: https://github.com/apache/hbase/pull/5481#discussion_r1373417312
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/SlowLogParams.java:
##########
@@ -82,7 +82,7 @@ public boolean equals(Object o) {
}
SlowLogParams that = (SlowLogParams) o;
return new EqualsBuilder().append(regionName,
that.regionName).append(params, that.params)
- .append("scan", scan).isEquals();
+ .append(scan, that.scan).isEquals();.isEquals();
Review Comment:
I also noticed this bug in the SlowLogParams equals implementation, but I
don't think it's related to the slow log payload corruption that we've observed
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/SlowLogParams.java:
##########
@@ -82,7 +82,7 @@ public boolean equals(Object o) {
}
SlowLogParams that = (SlowLogParams) o;
return new EqualsBuilder().append(regionName,
that.regionName).append(params, that.params)
- .append("scan", scan).isEquals();
+ .append(scan, that.scan).isEquals();
Review Comment:
I also noticed this bug in the SlowLogParams equals implementation, but I
don't think it's related to the slow log payload corruption that we've observed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
