bbeaudreault commented on PR #5481: URL: https://github.com/apache/hbase/pull/5481#issuecomment-1781872024
An alternative approach here might be to find a way to call ByteBuffer.retain() when creating the SlowLogParams, and then ByteBuffer.release() when consuming in SlowLogService. That might be a little tricker, but would probably be better in terms of GC and time spent copying. It sort of depends on the rate of slow logs. Looking briefly at it, I think we could possibly utilize the method @Apache9 added to RpcCall in [HBASE-22539](https://issues.apache.org/jira/browse/HBASE-22539) -- retainByWAL when enqueueing a RpcLogDetails, and then call releaseByWAL in SlowLogQueueService.consumeEventFromDisruptor. Obviously we'd need to rename the methods in that case. What do you think of that Duo? It seems like the exact same problem -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
