bbeaudreault commented on PR #5481:
URL: https://github.com/apache/hbase/pull/5481#issuecomment-1781829679

   This might seem silly, but I wonder if you could at least do the simple test 
of:
   
   - Create a protobuf and write it to a ByteBuffer
   - Create another protobuf backed by a CodedInputStream which wraps that 
ByteBuffer and enables aliasing
   - Pass the second protobuf into SlowLogParams
   - Corrupt the backing buffer of the CodedInputStream (write a bunch of 
random data)
   - call SlowLogParams.getParam() and validate that it equals the original 
protobuf
   
   This may not be our usual end-to-end test that proves the bug, but it at 
least proves the fix under the assumption that the bug is occurring 
periodically.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to