jbewing commented on code in PR #5576:
URL: https://github.com/apache/hbase/pull/5576#discussion_r1433252640
##########
hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValueUtil.java:
##########
@@ -226,7 +226,7 @@ public static KeyValue nextShallowCopy(final ByteBuffer bb,
final boolean includ
int kvLength = (int) KeyValue.getKeyValueDataStructureSize(keyLength,
valueLength, tagsLength);
KeyValue keyValue = new KeyValue(bb.array(), underlyingArrayOffset,
kvLength);
if (includesMvccVersion) {
- long mvccVersion = ByteBufferUtils.readVLong(bb);
+ long mvccVersion = ByteBufferUtils.readVLongTimestamp(bb);
Review Comment:
Just posted the raw benchmarking results [in the JIRA in this
comment](https://issues.apache.org/jira/browse/HBASE-28256?focusedCommentId=17799200&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17799200).
I haven't had the chance to go fully over it yet, but my preliminary thought
is that the optimization here and the recycler fix are worth it. It seems like
they each yield like a 50% performance improvement over our current setup
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
