bbeaudreault commented on code in PR #5576:
URL: https://github.com/apache/hbase/pull/5576#discussion_r1433154777
##########
hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValueUtil.java:
##########
@@ -226,7 +226,7 @@ public static KeyValue nextShallowCopy(final ByteBuffer bb,
final boolean includ
int kvLength = (int) KeyValue.getKeyValueDataStructureSize(keyLength,
valueLength, tagsLength);
KeyValue keyValue = new KeyValue(bb.array(), underlyingArrayOffset,
kvLength);
if (includesMvccVersion) {
- long mvccVersion = ByteBufferUtils.readVLong(bb);
+ long mvccVersion = ByteBufferUtils.readVLongTimestamp(bb);
Review Comment:
Oh, if the actual problem is the refcnt stuff, Duo and I had an idea for
that a while ago: https://issues.apache.org/jira/browse/HBASE-27730. It was
never implemented only because I was focused on the snapshot scan problem and
we hadn't actually seen evidence of the problem elsewhere
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
