jbewing commented on code in PR #5576:
URL: https://github.com/apache/hbase/pull/5576#discussion_r1433196386
##########
hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValueUtil.java:
##########
@@ -226,7 +226,7 @@ public static KeyValue nextShallowCopy(final ByteBuffer bb,
final boolean includ
int kvLength = (int) KeyValue.getKeyValueDataStructureSize(keyLength,
valueLength, tagsLength);
KeyValue keyValue = new KeyValue(bb.array(), underlyingArrayOffset,
kvLength);
if (includesMvccVersion) {
- long mvccVersion = ByteBufferUtils.readVLong(bb);
+ long mvccVersion = ByteBufferUtils.readVLongTimestamp(bb);
Review Comment:
That's a good callout. In lieu of that I'm going to update my
microbenchmarks to also test on ByteBuff's with a NONE recycler (I'm
intentionally not using the NONE recycler in my current microbenchmarks to
simulate real region server operation).
Here's the part of the flamegraph for `next()` that shows where the time is
going for `readVLong` et al
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
