d-c-manning commented on code in PR #6789:
URL: https://github.com/apache/hbase/pull/6789#discussion_r2020372302
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java:
##########
@@ -8441,9 +8446,9 @@ public void startRegionOperation(Operation op) throws
IOException {
// Update regionLockHolders ONLY for any startRegionOperation call that is
invoked from
// an RPC handler
Thread thisThread = Thread.currentThread();
- if (isInterruptableOp) {
Review Comment:
if this is changing then the comment on line 8441-8442 should also change
(we are no longer updating `regionLockHolders` ONLY for calls invoked from RPC
handlers, but also for internal operations like REPLAY, or COMPACT_REGION, or
SNAPSHOT, or ANY (used in several places, like batch mutate internal or refresh
store files.)
The comment should reflect the code. Similarly for the comment at the
declaration of `regionLockHolders` for the class. This assumes that the logic
change is okay, of course.
I do worry about the logic change, because of calls to `enableInterrupts`
and `disableInterrupts`. That will change the value of this flag in a way that
was not possible before (because it was not present before, and therefore
`computeIfPresent` would not do anything.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
