mnpoonia commented on code in PR #6789:
URL: https://github.com/apache/hbase/pull/6789#discussion_r2026287576
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java:
##########
@@ -8438,12 +8445,12 @@ public void startRegionOperation(Operation op) throws
IOException {
throw new
NotServingRegionException(getRegionInfo().getRegionNameAsString() + " is
closing");
}
lock(lock.readLock());
- // Update regionLockHolders ONLY for any startRegionOperation call that is
invoked from
- // an RPC handler
+ // Update regionLockHolders for every startRegionOperation call that is
invoked from
+ // either an RPC handler or otherwise. We will interrupt only RPC
operations
Review Comment:
>We have to decide first whether you want to change the current logic. I
assume you do not want to change the interrupting logic, and just want to
improve the logging. If that is true, then you want to do the following:
Thank you @d-c-manning . I misunderstood your last comment. I agree we don't
want to change interruption logic here. We want to just dump the right info in
logs to help with debugging in scenarios where locks becomes problematic and
cause region abort.
Let me rethink and update this code accordingly. Thanks again for spending
time on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
