mnpoonia commented on code in PR #6789:
URL: https://github.com/apache/hbase/pull/6789#discussion_r2026289877
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java:
##########
@@ -8438,12 +8445,12 @@ public void startRegionOperation(Operation op) throws
IOException {
throw new
NotServingRegionException(getRegionInfo().getRegionNameAsString() + " is
closing");
}
lock(lock.readLock());
- // Update regionLockHolders ONLY for any startRegionOperation call that is
invoked from
- // an RPC handler
+ // Update regionLockHolders for every startRegionOperation call that is
invoked from
+ // either an RPC handler or otherwise. We will interrupt only RPC
operations
Review Comment:
On another note i am thinking if it is okay to interrupt even the thread
that we were not interrupting before. Because anyway we are going to abort RS
which will kill all threads.
I am assuming that is a bigger change and should surely be not in this JIRA.
Maybe some other day and another JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
