haridsv commented on code in PR #7136:
URL: https://github.com/apache/hbase/pull/7136#discussion_r2190249013
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionScannerImpl.java:
##########
@@ -145,7 +150,18 @@ private static boolean hasNonce(HRegion region, long
nonce) {
} finally {
region.smallestReadPointCalcLock.unlock(ReadPointCalculationLock.LockType.RECORDING_LOCK);
}
+ boolean isScanMetricsEnabled = scan.isScanMetricsEnabled();
+
ThreadLocalServerSideScanMetrics.setScanMetricsEnabled(isScanMetricsEnabled);
+ if (isScanMetricsEnabled) {
+ ThreadLocalServerSideScanMetrics.reset();
+ }
initializeScanners(scan, additionalScanners);
+ if (isScanMetricsEnabled) {
+ bytesReadFromFs +=
ThreadLocalServerSideScanMetrics.getBytesReadFromFsAndReset();
Review Comment:
I meant from the logic, did you step through and see what read operations
were happening? Or is it just that you happened to see non-zero value at this
point and decided to capture the value?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
