anmolnar commented on code in PR #7445: URL: https://github.com/apache/hbase/pull/7445#discussion_r2525208055
########## hbase-server/src/main/java/org/apache/hadoop/hbase/replication/ReplicationResult.java: ########## @@ -0,0 +1,33 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.hbase.replication; + +import org.apache.hadoop.hbase.HBaseInterfaceAudience; +import org.apache.yetus.audience.InterfaceAudience; + [email protected](HBaseInterfaceAudience.REPLICATION) +public enum ReplicationResult { Review Comment: > I still do not think we need to introduce this new class... > > The current implementation will update the wal position every time when we finish sending out a batch, in general I think this could be changed, FWIW, we can increase the batch to reduce the time we persist the log position, so it is not a big problem to not always persist the position. I'm not sure I understand this. We're streaming the data to the S3 object, but we don't want to persist the WAL position every time a batch is shipped, only when we close the stream and open a new one. In order to persist WAL position every time a batch is shipped, the batch size must be equal to desired S3 object size. > In this way, we could add a callback when we actually want to persist the log position, to commit the data to external storage. I think in this way the logic more clear. I think this could work. The callback is passed to the shipper which will call it when it wants to persist. @vinayakphegde @ankitsol wdyt? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
