vinayakphegde commented on code in PR #7445: URL: https://github.com/apache/hbase/pull/7445#discussion_r2527528111
########## hbase-server/src/main/java/org/apache/hadoop/hbase/replication/ReplicationResult.java: ########## @@ -0,0 +1,33 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.hbase.replication; + +import org.apache.hadoop.hbase.HBaseInterfaceAudience; +import org.apache.yetus.audience.InterfaceAudience; + [email protected](HBaseInterfaceAudience.REPLICATION) +public enum ReplicationResult { Review Comment: Hi @Apache9, if I understand correctly what you're saying, taking your first option: > Every time or a fixed number of times (a number) I assume that if the fixed number is 10, for the first 9 times we push the batch, the endpoint consumes it and returns true, but we don’t move the offset. On the 10th time, the endpoint should mandatorily persist the file and then return true. Once the endpoint returns true, we assume it has persisted, and we move the offset. With this approach, we can stick to using only true/false without needing to pass the replication source to the endpoint for persistence. We’ll take a look into this and see if there could be any issues with this approach. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
