Apache9 commented on code in PR #7445: URL: https://github.com/apache/hbase/pull/7445#discussion_r2525479357
########## hbase-server/src/main/java/org/apache/hadoop/hbase/replication/ReplicationResult.java: ########## @@ -0,0 +1,33 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.hbase.replication; + +import org.apache.hadoop.hbase.HBaseInterfaceAudience; +import org.apache.yetus.audience.InterfaceAudience; + [email protected](HBaseInterfaceAudience.REPLICATION) +public enum ReplicationResult { Review Comment: What I mean is that, now our mechanism is to persist the log position after every batch right? But since we can change the batch size to tune the frequency of persisting log position, so logically there is no hard limit that we 'must' persist the log position after every batch. I think we can change the condition on whether we need to log position. 1. Every time or a fixed number of times(a number) 2. Uncommitted size 3. Time after last commit 4. Every time when moving to a new file(a flag) This can be a more general framework and do not need to introduce more concept. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
