hgromer commented on code in PR #7582:
URL: https://github.com/apache/hbase/pull/7582#discussion_r2727803013
##########
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/IncrementalBackupManager.java:
##########
@@ -228,15 +263,6 @@ private List<String> getLogFilesForNewBackup(Map<String,
Long> olderTimestamps,
} else if (currentLogTS > oldTimeStamp) {
resultLogFiles.add(currentLogFile);
}
-
- // It is possible that a host in .oldlogs is an obsolete region server
Review Comment:
I think this check is now superfluous, and we simply include the WAL file in
the current backup in the case you mention.
Check out
[this](https://github.com/apache/hbase/blob/d45cb7bdec8135441ecdb596b9427dc165f7a705/hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/IncrementalBackupManager.java#L256)
logic.
If we have a record of the hose the log file belongs to in our previous TS,
we can use that to compare against the log file. Otherwise, by default we add
it _unless_ the log file dates back to before savedStartCode.
The final piece is that we then update our boundaries based on _all_ the log
files we backup. So the new timestamp boundary for that host would be the TS
for L2.
Happy to continue discussing, let me know if you still disagree
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
