[
https://issues.apache.org/jira/browse/HBASE-6699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13445713#comment-13445713
]
stack commented on HBASE-6699:
------------------------------
Seems odd defining constant PSEUDO_METHOD_NAME_TO_SET_USER up in HConstants
when only used down in ipc package. Looks like something that should be
defined in Invocation and you'd add method to Invocation asking if its a
setUser invocation.
Indent if off for method callToSetUser
Does the callToSetUser w/ its new Invocation and Call have to happen always?
Can it not be off and if needed, enabled by config? Would mean Lars would be
more comfortable committing if default behavior was unchanged. Is it ok doing
it this way for you lot?
Why change the way the comment is done?
{code}
- // See HBaseServer.Call.setResponse for where we write out the
response.
- // It writes the call.id (int), a flag byte, then optionally the length
- // of the response (int) followed by data.
-
+ /**
+ * See {@link HBaseServer.Call#setResponse()} for where we write out
the
+ * response. It writes the call.id (int), a flag byte, then optionally
+ * the length of the response (int) followed by data.
+ */
{code}
The javadoc commenting convention will never be interpreted as so in middle of
method?
Is this log right?
{code}
+ LOG.error("Got exception while processing call with Id: " +id, e);
{code}
Did we used to just retry silently? If so, now our logs will have a bunch of
LOG.error? Is LOG.error appropriate if retry (I may be off... just reading the
patch, not looking at the patch context)
Where in HBaseServer do we actually make the Call after getting user name? I
see us returning Void but this is an invocation just to set user name over on
server?
> Setting username in Connection in non-secure HBase
> --------------------------------------------------
>
> Key: HBASE-6699
> URL: https://issues.apache.org/jira/browse/HBASE-6699
> Project: HBase
> Issue Type: Improvement
> Components: ipc
> Affects Versions: 0.92.0, 0.92.1, 0.94.0, 0.94.1
> Reporter: Himanshu Vashishtha
> Assignee: Himanshu Vashishtha
> Fix For: 0.92.3, 0.94.2
>
> Attachments: HBase-6699-v1.patch
>
>
> We recently had a requirement where we need to log the information about
> various users who were using non-secure HBase cluster.
> The user level logging is supported as part of security, but in 0.92, 0.94
> security related code is separate. This jira is about adding that support in
> non-secure code.
> This feature is already there in trunk, after we merge the security related
> code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
