[
https://issues.apache.org/jira/browse/HBASE-6699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13445722#comment-13445722
]
stack commented on HBASE-6699:
------------------------------
bq. re: PSEUDO_METHOD_NAME_TO_SET_USER: We do have other references to
HConstants though? For Cluster_ID?
I don't follow. HConstants is a bad pattern. Constants should be defined
where they are used if possible.
bq. re: Comments: As I was reading the related code, i tried to use /**/ for
multi line comments.
/** */ is for javadoc. This is not javadoc. In general, you should try to
minimize your changes. Makes it easier getting your patches in.
bq. No, we just closed the connection if in this code path. This error is just
to print which call made it so.
We failed silently w/ no other logging?
bq. re: HBaseServer: So, the username is set in RequestContext. Now, any code
which wants to log can call this and get the username.
I suppose I don't get it. In every request context or just one time? Where is
the actual request when we have this setuser trick going on?
> Setting username in Connection in non-secure HBase
> --------------------------------------------------
>
> Key: HBASE-6699
> URL: https://issues.apache.org/jira/browse/HBASE-6699
> Project: HBase
> Issue Type: Improvement
> Components: ipc
> Affects Versions: 0.92.0, 0.92.1, 0.94.0, 0.94.1
> Reporter: Himanshu Vashishtha
> Assignee: Himanshu Vashishtha
> Fix For: 0.92.3, 0.94.2
>
> Attachments: HBase-6699-v1.patch
>
>
> We recently had a requirement where we need to log the information about
> various users who were using non-secure HBase cluster.
> The user level logging is supported as part of security, but in 0.92, 0.94
> security related code is separate. This jira is about adding that support in
> non-secure code.
> This feature is already there in trunk, after we merge the security related
> code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
