[
https://issues.apache.org/jira/browse/HBASE-3896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13462156#comment-13462156
]
Cody Marcel commented on HBASE-3896:
------------------------------------
Mockito allows you to work with the class directly, but it seems that there is
still advantage to working on an interface. It would certainly make it more
injection friendly later. This is what I had in mind for the ServerManger.
Rename ServerManager -> BaseServerManager
extract interface from that and name it ServerManager.
> Make AssignmentManager standalone testable by having its constructor take
> Interfaces rather than a CatalogTracker and a ServerManager
> -------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-3896
> URL: https://issues.apache.org/jira/browse/HBASE-3896
> Project: HBase
> Issue Type: Task
> Reporter: stack
> Assignee: Cody Marcel
>
> If we could stand up an instance of AssignmentManager, a core fat class that
> has a bunch of critical logic managing state transitions, then it'd be easier
> writing unit tests around its logic. Currently its hard because it takes a
> ServerManager and a CatalogTracker, but a little bit of work could turn these
> into Interfaces. SM looks easy to do. Changing CT into an Interface instead
> might ripple a little through the code base but it'd probably be well worth
> it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira