[
https://issues.apache.org/jira/browse/HBASE-3896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13464063#comment-13464063
]
stack commented on HBASE-3896:
------------------------------
bq. I don't think that abstracting out the serverManger and catalogtracker has
any real value, at the moment. I don't think there are other implementations of
those classes, so pulling out an interface only makes things more complicated,
not less.
Other implementations would be mocks that implement the SM and CT Interfaces?
Otherwise, appreciate the interjection. Good input.
> Make AssignmentManager standalone testable by having its constructor take
> Interfaces rather than a CatalogTracker and a ServerManager
> -------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-3896
> URL: https://issues.apache.org/jira/browse/HBASE-3896
> Project: HBase
> Issue Type: Task
> Reporter: stack
> Assignee: Cody Marcel
>
> If we could stand up an instance of AssignmentManager, a core fat class that
> has a bunch of critical logic managing state transitions, then it'd be easier
> writing unit tests around its logic. Currently its hard because it takes a
> ServerManager and a CatalogTracker, but a little bit of work could turn these
> into Interfaces. SM looks easy to do. Changing CT into an Interface instead
> might ripple a little through the code base but it'd probably be well worth
> it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
