[
https://issues.apache.org/jira/browse/HBASE-3896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13462444#comment-13462444
]
stack commented on HBASE-3896:
------------------------------
[[email protected]] Go for it. Anything you can do to improve the
testability would be most welcome. You might consider breaking SM up into
multiple Interfaces. There'd be the methods used by AssignmentManager, and
then others could go into the Interface the master uses. Not sure if you could
make that clean of a distinction... but something to consider. Your SM plan
sounds great.
> Make AssignmentManager standalone testable by having its constructor take
> Interfaces rather than a CatalogTracker and a ServerManager
> -------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-3896
> URL: https://issues.apache.org/jira/browse/HBASE-3896
> Project: HBase
> Issue Type: Task
> Reporter: stack
> Assignee: Cody Marcel
>
> If we could stand up an instance of AssignmentManager, a core fat class that
> has a bunch of critical logic managing state transitions, then it'd be easier
> writing unit tests around its logic. Currently its hard because it takes a
> ServerManager and a CatalogTracker, but a little bit of work could turn these
> into Interfaces. SM looks easy to do. Changing CT into an Interface instead
> might ripple a little through the code base but it'd probably be well worth
> it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
