[ 
https://issues.apache.org/jira/browse/HBASE-6881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13464378#comment-13464378
 ] 

rajeshbabu commented on HBASE-6881:
-----------------------------------

@Jimmy,
bq.For the removed code, it is not needed, because if 
regionAlreadyInTransition, we already transition the state to offline state in 
the exception handling part.
there is a possibility that state can be changed to OPENING in handleRegion, 
after setting OFFLINE in exception handling part. That's why we are not 
aborting master even state is not offline/closed. We were able to produce this 
scenario while testing HBASE-6438. Please correct me if wrong.
                
> All regionservers are marked offline even there is still one up
> ---------------------------------------------------------------
>
>                 Key: HBASE-6881
>                 URL: https://issues.apache.org/jira/browse/HBASE-6881
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>         Attachments: trunk-6881.patch
>
>
> {noformat}
> +        RegionPlan newPlan = plan;
> +        if (!regionAlreadyInTransitionException) {
> +          // Force a new plan and reassign. Will return null if no servers.
> +          newPlan = getRegionPlan(state, plan.getDestination(), true);
> +        }
> +        if (newPlan == null) {
>            this.timeoutMonitor.setAllRegionServersOffline(true);
>            LOG.warn("Unable to find a viable location to assign region " +
>              state.getRegion().getRegionNameAsString());
> {noformat}
> Here, when newPlan is null, plan.getDestination() could be up actually.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to