[
https://issues.apache.org/jira/browse/HBASE-6881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13464875#comment-13464875
]
Jimmy Xiang commented on HBASE-6881:
------------------------------------
Really good question. It is great to work with you guys and the community.
My understanding is that you three all have concerns about the removed code.
I think it is ok to remove it. As stack pointed out, I think #1498 already
transitions the state to offline.
handRegion can not transition the state now since we already hold the locker
for this region, and will keep
the locker till the assign returns.
I will look into it more and think about if there is a better way to handle
RegionAlreadyInTransition.
> All regionservers are marked offline even there is still one up
> ---------------------------------------------------------------
>
> Key: HBASE-6881
> URL: https://issues.apache.org/jira/browse/HBASE-6881
> Project: HBase
> Issue Type: Bug
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Attachments: trunk-6881.patch
>
>
> {noformat}
> + RegionPlan newPlan = plan;
> + if (!regionAlreadyInTransitionException) {
> + // Force a new plan and reassign. Will return null if no servers.
> + newPlan = getRegionPlan(state, plan.getDestination(), true);
> + }
> + if (newPlan == null) {
> this.timeoutMonitor.setAllRegionServersOffline(true);
> LOG.warn("Unable to find a viable location to assign region " +
> state.getRegion().getRegionNameAsString());
> {noformat}
> Here, when newPlan is null, plan.getDestination() could be up actually.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
