[
https://issues.apache.org/jira/browse/HBASE-7405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13537682#comment-13537682
]
stack commented on HBASE-7405:
------------------------------
These look generic DD:
+message EmptyMsg {
+}
+
+message LongMsg {
+ required int64 longMsg = 1;
+}
Especially the first. Maybe belongs in hbase.proto?
What is going on here?
- public <R, S> R max(final byte[] tableName, final ColumnInterpreter<R, S> ci,
+ public <R, S, P extends Message, Q extends Message, T extends Message>
+ R max(final byte[] tableName, final ColumnInterpreter<R, S, P, Q, T> ci,
We have more args P, Q, and T. They extend Message. But I only see Q in the
below change in the method:
+ ByteString b = response.getFirstPart(0);
+ Q q = getCellMsgInstance(ci, b);
+ return ci.getCellValueFromProto(q);
Others use T and S. Are the added args doc'd?
The patch looks good but I'm not sure on what we are getting if we commit.
Thanks DD.
Pardon my being thick.
> Enforce PB ser/de for Aggregate protocol and associated ColumnInterpreter
> user code bits
> ----------------------------------------------------------------------------------------
>
> Key: HBASE-7405
> URL: https://issues.apache.org/jira/browse/HBASE-7405
> Project: HBase
> Issue Type: Sub-task
> Components: Coprocessors, Protobufs
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.96.0
>
> Attachments: 7405-1.patch, 7405-2.patch
>
>
> Enforce PB ser/de for Aggregate protocol and associated ColumnInterpreter
> user code bits
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
