[
https://issues.apache.org/jira/browse/HBASE-7405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13537687#comment-13537687
]
Devaraj Das commented on HBASE-7405:
------------------------------------
Thanks for the review, [~stack]. Responses below:
bq. Especially the first. Maybe belongs in hbase.proto?
Yes, I could put it there.. Will do.
{quote}
We have more args P, Q, and T. They extend Message. But I only see Q in the
below change in the method:
Others use T and S. Are the added args doc'd?
{quote}
Yeah, true. I did it this way just to have the same signature for all methods.
I think this makes it look better than the alternative..
On the javadoc, I think most of it is doc'ed. I'll make a pass over the patch
again with the doc in mind.
bq. The patch looks good but I'm not sure on what we are getting if we commit.
Thanks DD.
The thing we get is user code deals with PB only. In the earlier iteration of
the Aggregate/ColumnInterpreter conversion to use PB (HBASE-6785), I had kept
the user code ser/de generic (meaning users could do PB or anything else, and
the framework would treat user code bits as opaque bytes and hence the
ColumnInterpreter APIs had the ByteString/byte[] signatures). Over in
HBASE-6787 (http://bit.ly/Sq56RP), the consensus was to mandate PB in user code
as well, and this patch addresses that for Aggregate/ColumnInterpreter. Makes
sense?
> Enforce PB ser/de for Aggregate protocol and associated ColumnInterpreter
> user code bits
> ----------------------------------------------------------------------------------------
>
> Key: HBASE-7405
> URL: https://issues.apache.org/jira/browse/HBASE-7405
> Project: HBase
> Issue Type: Sub-task
> Components: Coprocessors, Protobufs
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.96.0
>
> Attachments: 7405-1.patch, 7405-2.patch
>
>
> Enforce PB ser/de for Aggregate protocol and associated ColumnInterpreter
> user code bits
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
