[
https://issues.apache.org/jira/browse/HBASE-3787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13567168#comment-13567168
]
Andrew Purtell commented on HBASE-3787:
---------------------------------------
bq. On region server, we need to keep a map from row key to set of nounce's,
per table, which reflect client requests the server has seen.
Don't see the need for row key or per table state. Something like
(client-address, nonce, timestamp) should be sufficient, right? Entry would be
unique enough. Add the entry when op processing starts, remove it when finished
or failed, refuse to process an op twice by sending back a DoNotRetryException.
As for minimizing heap, expired entries could be lazily collected during add or
remove of new entries or reaped by a chore.
> Increment is non-idempotent but client retries RPC
> --------------------------------------------------
>
> Key: HBASE-3787
> URL: https://issues.apache.org/jira/browse/HBASE-3787
> Project: HBase
> Issue Type: Bug
> Components: Client
> Affects Versions: 0.96.0, 0.94.4
> Reporter: dhruba borthakur
> Priority: Critical
> Fix For: 0.96.0
>
>
> The HTable.increment() operation is non-idempotent. The client retries the
> increment RPC a few times (as specified by configuration) before throwing an
> error to the application. This makes it possible that the same increment call
> be applied twice at the server.
> For increment operations, is it better to use
> HConnectionManager.getRegionServerWithoutRetries()? Another option would be
> to enhance the IPC module to make the RPC server correctly identify if the
> RPC is a retry attempt and handle accordingly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira