[ 
https://issues.apache.org/jira/browse/HBASE-3787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13567382#comment-13567382
 ] 

Anoop Sam John commented on HBASE-3787:
---------------------------------------

[~apurtell]
I am trying to understand the idea and try out implementing.
bq.Add the entry when op processing starts, remove it when finished or failed, 
refuse to process an op twice by sending back a DoNotRetryException.
Yes a retry from client side while in progress can be DNREed. What if the 
operation at server just completed and removed the entry and then a retry 
request comes from client. [Client has not received the response yet]
[[email protected]]
bq.Should table name be included in the hash ?
Depends on what layer we keep nonce info. If it is at the HRS level we might 
need table name also I think.
                
> Increment is non-idempotent but client retries RPC
> --------------------------------------------------
>
>                 Key: HBASE-3787
>                 URL: https://issues.apache.org/jira/browse/HBASE-3787
>             Project: HBase
>          Issue Type: Bug
>          Components: Client
>    Affects Versions: 0.96.0, 0.94.4
>            Reporter: dhruba borthakur
>            Priority: Critical
>             Fix For: 0.96.0
>
>
> The HTable.increment() operation is non-idempotent. The client retries the 
> increment RPC a few times (as specified by configuration) before throwing an 
> error to the application. This makes it possible that the same increment call 
> be applied twice at the server.
> For increment operations, is it better to use 
> HConnectionManager.getRegionServerWithoutRetries()? Another  option would be 
> to enhance the IPC module to make the RPC server correctly identify if the 
> RPC is a retry attempt and handle accordingly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to