[ 
https://issues.apache.org/jira/browse/HBASE-7763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13572616#comment-13572616
 ] 

Sergey Shelukhin commented on HBASE-7763:
-----------------------------------------

Is RatioRight "Ratio" in perf results?
RatioRight doesn't make intuitive sense to me. It is picking the same as 
original algo, except requiring that ratio condition be satisfied for all files 
inside compaction. 
Say you have 4 3 1 1, minfiles 2, ratio 1, does it make sense to compact 1 1? 
Is the goal to reduce compaction size?

As an aside, RatioRight doesn't appear to check minfiles-sized compaction for 
having valid ratio. E.g. 9 3 1, minfiles 2, ratio 1, 3 1 would get compacted.

With regard to sorting I'll comment later if seqNum issue is shown to be 
non-issue, I diffed them with the basic policy and in general the idea of 
sorting by size does make sense,

                
> Compactions not sorting based on size anymore.
> ----------------------------------------------
>
>                 Key: HBASE-7763
>                 URL: https://issues.apache.org/jira/browse/HBASE-7763
>             Project: HBase
>          Issue Type: Bug
>          Components: Compaction
>    Affects Versions: 0.96.0, 0.94.4
>            Reporter: Elliott Clark
>            Assignee: Elliott Clark
>            Priority: Critical
>             Fix For: 0.96.0, 0.94.6
>
>         Attachments: HBASE-7763-trunk-TESTING.patch, 
> HBASE-7763-trunk-TESTING.patch, HBASE-7763-trunk-TESTING.patch
>
>
> Currently compaction selection is not sorting based on size.  This causes 
> selection to choose larger files to re-write than are needed when bulk loads 
> are involved.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to