[
https://issues.apache.org/jira/browse/HBASE-7233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13573189#comment-13573189
]
Ted Yu commented on HBASE-7233:
-------------------------------
Fro KeyValueDecoder:
{code}
+ public boolean next() {
+ if (!this.hasNext) return !this.hasNext;
{code}
I think this.hasNext should be returned.
For TestBasicCellCodec:
{code}
+ public void testOne() throws IOException {
...
+ public void testThree() throws IOException {
{code}
Would testOneKeyValue(), testThreeKeyValue() be better names ?
Similar comment for TestCellMessageCodec.testOne()
For ProtobufUtil.java:
{code}
- builder.addKeyValue(toKeyValue(c));
+ builder.addKeyValue(toCell(c));
{code}
It would be nice if the method name for builder can be changed to addCell().
> Serializing KeyValues
> ---------------------
>
> Key: HBASE-7233
> URL: https://issues.apache.org/jira/browse/HBASE-7233
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Assignee: stack
> Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 7233sketch.txt, 7233.txt, 7233v10.txt, 7233-v2.txt,
> 7233v3_encoders.txt, 7233v4_encoders.txt, 7233v5_encoders.txt,
> 7233v6_encoder.txt, 7233v7.txt, 7233v9.txt
>
>
> Undo KeyValue being a Writable.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
