[ 
https://issues.apache.org/jira/browse/HBASE-7233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13573258#comment-13573258
 ] 

Matt Corgan commented on HBASE-7233:
------------------------------------

I like it.  Nice and simple.

What are your thoughts on BasicCellEncoder vs KeyValueEncoder?  Are you 
introducing the new "BasicCell" format because it's easier for a non-java 
client to decode?

KeyValueEncoder appears faster in this benchmark because the serialization is 
less granular, but I think that will become irrelevant over time if we get the 
Cell interface all the way up the read path.  It's faster now because you know 
the input cell is KeyValue so can just cast.  If you don't know the input Cell 
implementation, you'd have to append each KeyValue field separately.  

Would probably be good to include BasicCellEncoder and KeyValue encoder just to 
make sure that the necessary abstractions are in place to add future encodings. 
 Later on, my guess is one of the delta-style encoders will be best for java 
client RPC.
                
> Serializing KeyValues
> ---------------------
>
>                 Key: HBASE-7233
>                 URL: https://issues.apache.org/jira/browse/HBASE-7233
>             Project: HBase
>          Issue Type: Bug
>            Reporter: stack
>            Assignee: stack
>            Priority: Blocker
>             Fix For: 0.96.0
>
>         Attachments: 7233sketch.txt, 7233.txt, 7233v10.txt, 7233-v2.txt, 
> 7233v3_encoders.txt, 7233v4_encoders.txt, 7233v5_encoders.txt, 
> 7233v6_encoder.txt, 7233v7.txt, 7233v9.txt
>
>
> Undo KeyValue being a Writable.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to