[
https://issues.apache.org/jira/browse/HBASE-7233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13573259#comment-13573259
]
stack commented on HBASE-7233:
------------------------------
I think we should close this issue now. Its scope has wandered and we got a
bunch of use out of it but I think its time has come.
The original intent was removing Writable from KV which has happened over in
another issue. How KVs went across MapReduce when not Writable came up and
that got fixed out in other issues also.
We then did a bunch of the back and forth on how to serialize KVs particularly
across RPC.
Most of the discussion has been captured here:
https://docs.google.com/document/d/1WEtrq-JTIUhlnlnvA0oYRLp0F8MKpEBeBSCFcQiacdw/edit#
...and will be realized in code over in the rpc revamp issue, HBASE-7533
(patches added here will reappear in that issue)
Regards Andrew's request regards HBASE-6222 above on being able to pass a
KeyValue version2, a v2 should make
it across the rpc and even into hfiles (after doing some work on
EncodedDataBlocks so they sling Cells instead
of KVs) but what is required will not happen in this issue.
The client and server will need to all be moved to reference the Cell Interface
rather than KV1 as they currently do. Only then could a KV2 traverse the
client and server. That is work to do (As Lars Hofhansl's found out, doing
this often makes for speedups since we
are often realizing KVs when all we need is a piece). Lets take up the effort
to change the servers to be Cell based
rather than KV elsehwere.
The EncodedDataBlocks revamp should happen elsewhere too.
Neither of the above should hold up 0.96 release (A 0.96 client should be able
to talk to
a future server that can do KV version 2).
Should we add anything to the Cell Interface before 0.96 ships; e.g. the
getTagsArray, etc., Matt suggets above for Andrew's tag work? If so, lets get
that in.
Will close in a day or two unless objection.
> Serializing KeyValues
> ---------------------
>
> Key: HBASE-7233
> URL: https://issues.apache.org/jira/browse/HBASE-7233
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Assignee: stack
> Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 7233sketch.txt, 7233.txt, 7233v10.txt, 7233-v2.txt,
> 7233v3_encoders.txt, 7233v4_encoders.txt, 7233v5_encoders.txt,
> 7233v6_encoder.txt, 7233v7.txt, 7233v9.txt
>
>
> Undo KeyValue being a Writable.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
